Cleanup some settings from settings_test.py #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 17, 2024
Thanks for the review. The test failures I was referring to was in the optimize code path, which is kind of complicated to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the investigation of #6279, I found that:
OPTIMIZE_JOB_CUTOFF_TIMEis overridden to24and it was causing test failures.OPTIMIZE_PARALLEL_MAX_JITTER_MINUTESdoes not seem to be used anywhere in the code.With the change, less no. of local tests fail. The failure number is non-zero because #6279 was reverted yesterday . I would like to verify if this small change passes through the CI and stays stable in prod.