Ensure optimizers return updates of same dtype as params. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_674026550
branch
from
6ef174d
to
dba413f
Compare
copybara-service
bot
force-pushed
the
test_674026550
branch
2 times, most recently
from
a33ee43
to
0f3e2f7
Compare
Closed
copybara-service
bot
force-pushed
the
test_674026550
branch
from
0f3e2f7
to
02bf1b1
Compare
This was referenced Sep 14, 2024
copybara-service
bot
force-pushed
the
test_674026550
branch
9 times, most recently
from
ff23d8d
to
36b0622
Compare
copybara-service
bot
force-pushed
the
test_674026550
branch
3 times, most recently
from
c108820
to
c15e795
Compare
copybara-service
bot
force-pushed
the
test_674026550
branch
from
c15e795
to
25f870b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure optimizers return updates of same dtype as params.
Fix #1038, fix #377, fix #1051