Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore survey clicks while the survey is being activated. #2740

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

sufyanAbbasi
Copy link
Contributor

Fixes #2729

Prevent secondary loading of survey while the current survey is still being loaded. Unfortunately, there still exists UX problems of the user not getting any feedback about the survey still in the loading state even after the loading bar has gone away.

@gino-m PTAL!

@sufyanAbbasi sufyanAbbasi requested a review from gino-m September 18, 2024 21:08
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.89%. Comparing base (7cffa80) to head (f0a9335).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...round/ui/surveyselector/SurveySelectorViewModel.kt 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2740      +/-   ##
============================================
- Coverage     60.91%   60.89%   -0.03%     
  Complexity     1164     1164              
============================================
  Files           265      265              
  Lines          6046     6050       +4     
  Branches        839      839              
============================================
+ Hits           3683     3684       +1     
- Misses         1893     1895       +2     
- Partials        470      471       +1     
Files with missing lines Coverage Δ
...round/ui/surveyselector/SurveySelectorViewModel.kt 93.18% <25.00%> (-6.82%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required survey answers logged as "Skipped"
2 participants