Are there any plans to merge the "bitmap-glyphs" branch?

[LaurenzV]

Some time ago I noticed that there is a branch containing a skrifa API for bitmap glyphs (https://github.com/googlefonts/fontations/blob/skrifa-bitmaps/skrifa/src/bitmap.rs). From what I saw, right now the code is duplicated in vello, and I had to duplicate it for my crate as well, but apart from one minor fix I had to apply, it seems to work pretty nicely. :)

So I was wondering whether there are plans on actually integrating this into skrifa, or whether there is a reason this hasn't been done yet?

[LaurenzV]

Also FYI, the fix I had to apply was changing

if glyph.graphic_type() != Tag::new(b"PNG ") {
    return None;
}

to

if glyph.graphic_type() != Tag::new(b"png ") {
    return None;
}

[dfrg]

Thanks for the fix. I’d like to land this in skrifa but it hasn’t been a high priority because we already have equivalent functionality in Skia and, as you mentioned, we simply copied the code into vello. I’ll try to find some time in the next couple weeks to get it merged.