Add a small emoji picker/selector example #420
Conversation
|
I tested this, and the fonts are not visible on Mac OS. Maybe the font isn't COLR format. |
|
Indeed. This is called out in linebender/linebender.github.io#56, for example. |
|
Moving this into draft due to the lack of bitmap emoji support. |
|
This should start working properly once we have Vello 0.3 and Parley 0.2. See #616 |
The biggest remaining issue in this PR is that IME support is not present. However, I think landing this is *better* than not landing it, because: 1) If we don't land it, it's going to languish again 2) Getting IME support back can be parallelised (cc @tomcur) 3) Getting Vello 0.3.0 and Parley 0.2.0 unlocks real advantages, including full emoji support (#420). To be clear, my first follow-up priority will be connecting the IME back up. I do not however think this should block on Parley 0.3.0. Discussion in https://xi.zulipchat.com/#narrow/channel/317477-masonry/topic/Updating.20Parley.20dependency
Add license heading Add accessibility comments Fix clippy and formatting Fix android compilation
DJMcNab
force-pushed
the
emoji_picker
branch
from
a2fd33d to
aa01d46
Compare
|
Are emojis on non-COLR fonts out of scope for this PR? It still does not show emojis on MacOS. |
|
Hmm... It supports bitmap and COLR emoji - it works on my desktop Linux machine. @dfrg do we expect this to work with the Emoji support in Parley/Vello as-is? |
|
I think we make an attempt to do proper emoji font selection. It should work fairly well on Mac/Windows. Linux will depend on installed fonts and fontconfig setup. |
|
@jaredoconnell then I'm going to have to ask you to debug this. I don't have a Mac to test with |
|
Are there any resources or documentation I should use to debug this? |
|
Actually, @LaurenzV discovered a bug in the sbix bitmap code here: https://github.com/linebender/vello/blob/98192612d9f4b7aed9b3223680527473ec449ee9/vello/src/scene/bitmap.rs#L165 The tag should be “png “. This will need to be fixed to properly handle Apple Color Emoji. |
|
@LaurenzV are you willing to make that PR to Vello? Edit: I now see the context that this was googlefonts/fontations#1167 (comment); I'll leave it open today since it is your change, but otherwise I'll open it myself in Vello. |
|
If you could do it, that would be great! If not I'll try to do it in the next few days. |
See googlefonts/fontations#1167 (comment) Should make linebender/xilem#420 work. Co-authored-by: Laurenz Stampfl <47084093+LaurenzV@users.noreply.github.com>
This depends on:
These are all present on Masonry main.
Some notes:
Gridwidget/ViewThis is created for linebender/linebender.github.io#56