Update to Vello 0.3.0, Parley main, AccessKit 0.17 #616
Conversation
|
I tested a few examples in Windows with Nvidia and MacOS with M1 Pro and I cannot see any differences. |
Note that this does *not* update to Parley 0.2.0 (git), because that requires a lot more work.
These are mostly because of linebender/parley#84
DJMcNab
changed the title
|
I experienced a panic while testing http_cats, but it doesn't look related to these changes, so I created an issue. But it might be. #750 |
|
There appears to be a problem with the cursor position in Prose (and potentially others) when not left aligned. When clicking on a middle aligned block of text, the cursor ends up far to the right. In the case of the Prose for HTTP Status Code, at the default window size the cursor is placed 16 characters too far to the right. |
|
Other regressions I found include the text within the progress bar not updating in the So there are no hard regressions, but these problems should likely be fixed before merging. |
|
Fixed the Prose issue by depending on linebender/parley#176. As you identified, #750 is a new regression from this PR, but only because it makes |
There was a problem hiding this comment.
It's not perfect, but with the exception of the shrinking empty textboxes, all bugs I've found are new and do not regress existing functionality.
I left a few comments about small issues I found. Another small issue is using an accessibility reader along with shift left/right to select results in accessibility only listing the newly selected character. I'm not sure if that's correct behavior.
Before this is merged it likely makes sense to merge the parley PR into main and depend on that instead of the branch.
| ctx.submit_action(crate::Action::TextEntered(self.text().to_string())); | ||
| return; | ||
| // let (fctx, lctx) = ctx.text_contexts(); | ||
| // self.editor | ||
| // .transact(fctx, lctx, |txn| txn.insert_or_replace_selection("\n")); | ||
| } |
There was a problem hiding this comment.
At some point in the future we need to allow configuration of enter behavior. There are definitely instances where enter should submit. Others where it should add a new line. And in some applications, shift-enter should be new line.
| pub fn select_word_at_point(&mut self, x: f32, y: f32) { | ||
| self.refresh_layout(); | ||
| self.editor | ||
| .set_selection(Selection::word_from_point(&self.editor.layout, x, y)); |
There was a problem hiding this comment.
The behavior of this doesn't seem correct when I use the editor. It selects the work then something messes it up so that it only selects the word left of the pointer. I don't know if the problem is here, where this function is called, or in Parley.
If this isn't addressed in this PR it would make sense to file an issue to fix it later. This isn't a blocker because there was no double click to select in the prior code.
There was a problem hiding this comment.
This should reproduce in Parley's vello_editor example, I think
| { | ||
| /// Get the contexts needed to build and paint text sections. | ||
| /// | ||
| /// Note that in many cases, these contexts are. |
There was a problem hiding this comment.
I have no idea what I wanted to say here...
The biggest remaining issue in this PR is that IME support is not present.
However, I think landing this is better than not landing it, because:
To be clear, my first follow-up priority will be connecting the IME back up. I do not however think this should block on Parley 0.3.0.
Discussion in https://xi.zulipchat.com/#narrow/channel/317477-masonry/topic/Updating.20Parley.20dependency