simplify icon construction: remov redundant div

googlefonts · Sep 17, 2023 · 46a1d6a · 46a1d6a
1 parent cd17e46
commit 46a1d6a
Showing 1 changed file with 12 additions and 16 deletions.
diff --git a/src/fontra/views/editor/panel-designspace-navigation.js b/src/fontra/views/editor/panel-designspace-navigation.js
@@ -889,25 +889,21 @@ function suggestedSourceNameFromLocation(location) {
 function makeIconCellFactory(iconPaths, triggerOnDoubleClick = false) {
   return (item, colDesc) => {
     const value = item[colDesc.key];
+    const clickSymbol = triggerOnDoubleClick ? "ondblclick" : "onclick";
     const iconElement = html.createDomElement("inline-svg", {
       src: iconPaths[boolInt(value)],
-    });
-    const clickSymbol = triggerOnDoubleClick ? "ondblclick" : "onclick";
-    return html.div(
-      {
-        style: "width: 1.2em; height: 1.2em;",
-        ondblclick: (event) => {
-          event.stopImmediatePropagation();
-        },
-        [clickSymbol]: (event) => {
-          const newValue = !item[colDesc.key];
-          item[colDesc.key] = newValue;
-          iconElement.src = iconPaths[boolInt(newValue)];
-          event.stopImmediatePropagation();
-        },
+      style: "width: 1.2em; height: 1.2em;",
+      ondblclick: (event) => {
+        event.stopImmediatePropagation();
       },
-      [iconElement]
-    );
+      [clickSymbol]: (event) => {
+        const newValue = !item[colDesc.key];
+        item[colDesc.key] = newValue;
+        iconElement.src = iconPaths[boolInt(newValue)];
+        event.stopImmediatePropagation();
+      },
+    });
+    return iconElement;
   };
 }