Update lint_options.config tag
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadkahelghi-grabtaxi
requested review from
minkuanlim-grabtaxi,
vanminh-grabtaxi,
arunsampathkumar-grabtaxi,
stevenchao-grabtaxi,
arnav-grabtaxi and
adarsh-grabtaxi
as code owners
| @@ -64,7 +64,7 @@ def android_library( | |||
| resources = [file for file in resource_files if file.endswith(".xml")], | |||
| manifest = attrs.get("manifest"), | |||
| baseline = lint_baseline, | |||
| lint_config = lint_options.get("lint_config", None), | |||
| lint_config = lint_options.get("config", None), | |||
There was a problem hiding this comment.
We will change on grazel too?
There was a problem hiding this comment.
not really this is just to be aligned with grazel
arunsampathkumar-grabtaxi
approved these changes
Mar 13, 2024
arunsampathkumar-grabtaxi
changed the title
lint_options.config tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update config tag