Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint_options.config tag #150

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Update lint_options.config tag #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/android/android_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def android_binary(
resources = [file for file in resource_files if file.endswith(".xml")],
manifest = attrs.get("manifest"),
baseline = lint_baseline,
lint_config = lint_options.get("lint_config", None),
lint_config = lint_options.get("config", None),
)

# Build deps
Expand Down
2 changes: 1 addition & 1 deletion rules/android/android_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def android_library(
resources = [file for file in resource_files if file.endswith(".xml")],
manifest = attrs.get("manifest"),
baseline = lint_baseline,
lint_config = lint_options.get("lint_config", None),
lint_config = lint_options.get("config", None),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will change on grazel too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really this is just to be aligned with grazel

)
android_library_deps = android_library_deps + [lint_sources_target]
lint(
Expand Down
2 changes: 1 addition & 1 deletion rules/kotlin/kotlin.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def kt_jvm_library_interal(
name = lint_sources_target,
srcs = attrs.get("srcs"),
baseline = lint_baseline,
lint_config = lint_options.get("lint_config", None),
lint_config = lint_options.get("config", None),
)

lint(
Expand Down
Loading