Update type_histogram.R #288
Conversation
do not force common break points across facets. this can be done through the break option. however, passing a vector to break is currently broken as is.null() is not vectorised.
| @@ -39,7 +39,7 @@ type_hist = type_histogram | |||
| data_histogram = function(breaks = "Sturges") { | |||
| hbreaks = breaks | |||
| fun = function(by, facet, ylab, col, bg, ribbon.alpha, datapoints, .breaks = hbreaks, ...) { | |||
| hbreaks = ifelse(!is.null(.breaks), .breaks, "Sturges") | |||
| hbreaks = ifelse(!mapply(is.null, .breaks), .breaks, "Sturges") | |||
There was a problem hiding this comment.
mapply is nice and concise. But it's more efficient (safer) to use something like:
!vapply(.breaks, function(x) is.null(x), FUN.VALUE = logical(1)Or, perhaps even:
any(lengths(.breaks) == 0)There was a problem hiding this comment.
Come to think of it, couldn't we just check the first element of .breaks? I'm trying to think of situations where the first element would be NULL but the others not (or, vice verse)....
| datapoints_breaks = hist(datapoints$x, breaks = hbreaks, plot = FALSE) | ||
| datapoints = split(datapoints, list(datapoints$by, datapoints$facet)) | ||
| datapoints = Filter(function(k) nrow(k) > 0, datapoints) | ||
|
|
||
| datapoints = lapply(datapoints, function(k) { | ||
| h = hist(k$x, breaks = datapoints_breaks$breaks, plot = FALSE) | ||
| h = hist(k$x, breaks = hbreaks, plot = FALSE) |
There was a problem hiding this comment.
I don't think we can delete the datapoints_breaks object, since we we should still use it by default in the case of grouped histograms. The thing we want to avoid is different binning widths for each group (unless the user explicitly requests it) which is why we calculate it on the full dataset first.
There was a problem hiding this comment.
sure, but atm there is no possibility of different binning for each group/facet since datapoint_breaks is always passed to breaks, and there is no possibility of passing a vector of breaks because of ifelse(). it would be nice if breaks accepted the same possibilities as hist (function, vector, number).
i think that different binning by group/facet often makes sense when freq=FALSE (missing atm).
thanks for looking into this!
do not force common break points across facets. this can be done by passing break points to the
breakoption. however, passing a vector tobreakis currently broken asis.null()is not vectorised.see here for some background