IMPLEMENT WEBSOCKETS #104
Merged
IMPLEMENT WEBSOCKETS #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also introduce ClientOptions
mostly empty boilerplate handlers, this includes both websocket types and event message types, both of which are based on outdated data and will likely require changes
because apparently the api is inconsistent with this
and update appropriate files
i sure hope this is already implemented everywhere lol
this is actually an enormous performance issue causing it to take 100x longer to fetch messages by using a separate API request for every single message in the group, thank god it's fixed now :clueless: Closes a huge issue that was present for years but isn't tracked because I forgot to open an issue for it
This reverts commit 9606cec.
oopsie. also add a bunch of method stubs to make all the managers compliant with the new abstract method
this didn't even compile before, not sure how it got this way to begin with
everything works now pog
WEBSOCKETS ARE HERE LET'S GOOOOOO BREAKING CHANGE: WEBSOCKETS ARE HERE!!!!!! only took 1 year to complete B)
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Websockets are finally here, bask in the glory of real-time event handling
Very few events are currently implemented, but the most important one (
line.create) is there and more can now be easily implemented by whoever feels like doing it