Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display map layer contributors #11

Closed
oliviasculley opened this issue Oct 4, 2023 · 6 comments · Fixed by #23
Closed

Display map layer contributors #11

oliviasculley opened this issue Oct 4, 2023 · 6 comments · Fixed by #23
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@oliviasculley
Copy link
Member

Similar to hackgvl/OpenData#54, it would be nice to display credits for the maintainers of the map layers when they are loaded.

This could also be expanded into a mechanism to contribute as described in #10

@ThorntonMatthewD
Copy link
Collaborator

Is the idea for information be displayed for each active layer?

@oliviasculley
Copy link
Member Author

I think so, but the specifics of how can be up to you 😄

@ThorntonMatthewD
Copy link
Collaborator

Screenshot_2023-10-07_19-42-35

I think the built-in "attribution bar" could get really busy if more than just one set of markers is active at one time, and we are displayed maintainer/contribution links for all of them. I like the idea of using this element to make a call out to hg-labs and the How to Contribute page, though.

@ThorntonMatthewD
Copy link
Collaborator

ThorntonMatthewD commented Oct 11, 2023

I'm still getting my bearings with Vue and Tailwind, but this is a prototype of what I've been envisioning:

contributors-popup.mp4

I'd appreciate any feedback anyone may have on this. I'm still working on the finer points around the styling, but I think the overall picture is there.

Edit:

Here it is on the mobile view.

contributors-popup-mobile.mp4

@oliviasculley
Copy link
Member Author

oliviasculley commented Oct 11, 2023

This looks fantastic! I think the only catch with this solution is making sure that it is accessible with screen readers and such, but for now we can just get this implemented, and then work on fixing any accessibility warnings that appear when viewing it in chrome or firefox, and then maybe adding better accessibility checks/tests to the CI pipeline like in #18. But all of this is outside of the scope of this issue. I'm really excited for this PR 😄

@ThorntonMatthewD
Copy link
Collaborator

Thank you so much! I do have a few aria labels to add to some elements to get the accessibility score back up. I'll make sure that's all polished before I submit this for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants