-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor body parts hierarchy on 8.2.0 mediawiki #167
Conversation
***** Knee <nowiki>[A joint connecting the lower part of the femur with the upper part of the tibia.]</nowiki> | ||
***** Shin <nowiki>[Front part of the leg below the knee.]</nowiki> | ||
***** Thigh <nowiki>[Upper part of the leg between hip and knee.]</nowiki> | ||
******* Teeth <nowiki>[The hard bonelike structures in the jaws. A collection of teeth arranged in some pattern in the mouth or other part of the body.]</nowiki> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that Teeth should go under Mouth.... Teeth is not a Mouth.
***** Torso-back <nowiki>[The rear surface of the human body from the shoulders to the hips, often regarded as the back]</nowiki> | ||
***** Abdomen <nowiki>[The part of the body between the thorax and the pelvis.]</nowiki> | ||
***** Pelvis <nowiki>[The bony structure at the base of the spine supporting the legs.]</nowiki> | ||
****** Buttocks <nowiki>[The round fleshy parts that form the lower rear area of a human trunk.]</nowiki> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Buttocks should go under Pelvis. It should be at the same level. It is possible that we need to do:
**** Torso
**** Torso-part
***** Buttocks
Now that we are going to ontologies -- a strict is-a will be enforced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teeth is in the Mouth (cavity). The same way that is under the Head hierarchy?
***** Hand <nowiki>[The distal portion of the upper extremity. It consists of the carpus, metacarpus, and digits.]</nowiki> | ||
***** Wrist <nowiki>[A joint between the distal end of the radius and the proximal row of carpal bones.]</nowiki> | ||
****** Palm <nowiki>[The part of the inner surface of the hand that extends from the wrist to the bases of the fingers.]</nowiki> | ||
****** Knuckles <nowiki>[A part of a finger at a joint where the bone is near the surface, especially where the finger joins the hand.]</nowiki> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here with adding parts. We need to discuss...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the Wrist should be under Hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reorganization has raised an interesting issue. All of the items in this hierarchy are "Body-part". We have both Body and Body-part at the top level -- but the whole-part relationship was not followed. We should probably discuss. With the ontology addition we can add part-of relationships, but the HED hierarchy should probably do a strict is-a.
I think we have to modify the schema under @smakeig @monique2208 @neuromechanist @dorahermes @dungscout96 : As a reminder we already had this discussion in the transition from HED2 to HED3. HED2 had a mixed hierarchy with
One thing that we could do is to introduce an |
I'll close this PR and open another one based on the Pre-release Schema. |
Following the discussion in #164, these changes will add a couple of terms and lightly adjust the anatomical hierarchy.
This pull request will close #164.