Skip to content

Commit

Permalink
Updated consolidated json tests (#622)
Browse files Browse the repository at this point in the history
* Updated tests and descriptions of duration handling (#620)

* Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID

* Merged NODE_NAME_EMPTY into TAG_INVALID

* Corrected additional NODE_NAME_EMPTY_LINKS

* Lower the schema version on two tests back

* Made hed_error_codes.json only contain codes with json files

* Add hedID validation tests

* Updated some of invalid characters

* Updated the JSON tests to have all fields

* Updated tests to include warning and alt_code in non-schema tests

* Updated the tests with additional alt-codes

* Definition may have no inner group

* Minor update in appendix B errors

* Minor changes to tests

* Corrected a typo in the specification

* Correction to curly brace test

* Modified the test for definition with no group

---------

Co-authored-by: IanCa <ianrcallanan@gmail.com>

* Updated spec tests and description of Duration handling (#621)

* Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID

* Merged NODE_NAME_EMPTY into TAG_INVALID

* Corrected additional NODE_NAME_EMPTY_LINKS

* Lower the schema version on two tests back

* Made hed_error_codes.json only contain codes with json files

* Add hedID validation tests

* Updated some of invalid characters

* Updated the JSON tests to have all fields

* Updated tests to include warning and alt_code in non-schema tests

* Updated the tests with additional alt-codes

* Definition may have no inner group

* Minor update in appendix B errors

* Minor changes to tests

* Corrected a typo in the specification

* Correction to curly brace test

* Modified the test for definition with no group

---------

Co-authored-by: IanCa <ianrcallanan@gmail.com>

* Reran consolidation tests

---------

Co-authored-by: IanCa <ianrcallanan@gmail.com>
  • Loading branch information
VisLab and IanCa authored Sep 13, 2024
1 parent 6cdf4d8 commit ba7e3cb
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion tests/javascript_tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,6 @@
"alt_codes": [
"TAG_EMPTY"
],
"name": "definition-invalid-empty-inner-group",
"description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
"warning": false,
"schema": "8.3.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/json_tests/DEFINITION_INVALID.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
{
"error_code": "DEFINITION_INVALID",
"alt_codes": ["TAG_EMPTY"],
g "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
"description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
"warning": false,
"schema": "8.3.0",
"definitions": ["(Definition/Acc/#, (Acceleration/#, Red))", "(Definition/MyColor, (Label/Pie))"],
Expand Down
1 change: 0 additions & 1 deletion tests/python_tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,6 @@
"alt_codes": [
"TAG_EMPTY"
],
"name": "definition-invalid-empty-inner-group",
"description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
"warning": false,
"schema": "8.3.0",
Expand Down

0 comments on commit ba7e3cb

Please sign in to comment.