Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 dev experimental #8

Open
wants to merge 5 commits into
base: ROS2_dev
Choose a base branch
from
Open

Ros2 dev experimental #8

wants to merge 5 commits into from

Conversation

neilpat02
Copy link
Collaborator

I added 2 new herocube bots to the robots.json. additionally the current experimental branch with minimal changes is currently the most up-to-date working instance of the heroswarm platform and needs a merge.

Copy link
Member

@MichaelStarks MichaelStarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the requested proof of testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should either remove this line or make it print as a debug message to the ros console with log_debug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a picture of /active_robots with the new robot names showing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did this but add a picture of the neopixel working after sending a ros message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants