[IR][Parser] Hidet IR grammar, parser and ir reconstructor #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaoyaoding, is it possible to add a dependency on lark? |
|
Yeah, we can add the dependency. |
yaoyaoding
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Roughly go through the parser and dumper, and they look good to me.
Thanks for the efforts @Aalanli !
|
Thanks @Aalanli ! |
vadiklyutiy
added a commit
that referenced
this pull request
Jul 22, 2024
Promote nvidia docker container to version 24.4 => Getting pytorch 2.3 Regression passed https://github.com/CentML/hidet/actions/runs/9964867474
vadiklyutiy
added a commit
that referenced
this pull request
Jul 23, 2024
Promote nvidia docker container to version 24.4 => Getting pytorch 2.3 Regression passed https://github.com/CentML/hidet/actions/runs/9964867474
vadiklyutiy
added a commit
that referenced
this pull request
Dec 26, 2024
Promote nvidia docker container to version 24.4 => Getting pytorch 2.3 Regression passed https://github.com/CentML/hidet/actions/runs/9964867474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all IR roundtrips correctly in the test suite, for all passes. The text is identical except for the attention ir module, which has trivial changes (eg. (0 == wj) -> (wj == 0), or (!false) -> true).
Also fixed inline let stmt pass, so that types of tensors do not change midway.
We need to add a dependency on lark, as the parser it generates is not correct (does not have the same behavior as the original).