fix yaxis attributes on jquery2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`data-graph-yaxis-X-*` attributes doesn't work on jQuery 2 (but `data-graph-yaxisX-*` work). `data-graph-yaxis-X-*` works on the master branch of jQuery. In order to have a version that work on all jQury versions we have to support the `data-graph-yaxisX-*` version that will be the new norm. To avoid a Backward compatibility break, we need to support both versions of the attribute. * Now all `data-graph-yaxis` attributes could be written with or without a dash before the axis number. * There is tests on all the attributes, in both versions * tests are executed on both jQuery 2 and jQuery 1 see issue highchartTable#60
Conflicts: .travis.yml
agallou
added a commit
that referenced
this pull request
Dec 6, 2015
fix yaxis attributes on jquery2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-graph-yaxis-X-*attributes doesn't workon jQuery 2 (but
data-graph-yaxisX-*work).data-graph-yaxis-X-*works on the master branchof jQuery.
In order to have a version that work on all
jQury versions we have to support the
data-graph-yaxisX-*version that will be the new norm.
To avoid a Backward compatibility break, we need to
support both versions of the attribute.
data-graph-yaxisattributes could be writtenwith or without a dash before the axis number.
see issue #60