Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix yaxis attributes on jquery2 #75

Merged
merged 3 commits into from
Dec 6, 2015
Merged

fix yaxis attributes on jquery2 #75

merged 3 commits into from
Dec 6, 2015

Commits on Nov 15, 2015

  1. fix yaxis attributes on jquery2 

    `data-graph-yaxis-X-*` attributes doesn't work
on jQuery 2 (but `data-graph-yaxisX-*` work).
`data-graph-yaxis-X-*` works on the master branch
of jQuery.

In order to have a version that work on all
jQury versions we have to support the `data-graph-yaxisX-*`
version that will be the new norm.

To avoid a Backward compatibility break, we need to
support both versions of the attribute.

* Now all `data-graph-yaxis` attributes could be written
with or without a dash before the axis number.
* There is tests on all the attributes, in both versions
* tests are executed on both jQuery 2 and jQuery 1

see issue highchartTable#60
    @agallou
    agallou committed Nov 15, 2015
    Configuration menu
    Copy the full SHA
    e640b5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into yaxis_jquery2 

    Conflicts:
	.travis.yml
    @agallou
    agallou committed Nov 15, 2015
    Configuration menu
    Copy the full SHA
    54f9868 View commit details
    Browse the repository at this point in the history

  3. fix sauelabs credentials

    @agallou
    agallou committed Nov 15, 2015
    Configuration menu
    Copy the full SHA
    36f1f78 View commit details
    Browse the repository at this point in the history