-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks for duplicate constraints. #461
Conversation
On constraint creation checks are added to see if it exists on the selected entity or entitiies. The exists method was added to GenericConstraintOp for this. Line distances have been replaced for point to point distances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me besides the two comments.
To migrate existing constraints:
|
Yes I figured this out yesterday, but while looking trough it I noticed the versioning system is broken for blender before 4.20 because of the changes made in the last month. I'll create another bug report... |
Simplified the exists method in base_constraint not to do specific checks and moved this logic into the add_distance operator. Added version check for older drawings. This updates all distance constraints on a line to the endpoints of that line. Changed addon version from 0.27.3 to 0.27.4
Think this is all. I added quite some checks into versioning to be really sure to select only the right ones (since e.g. angle constraints are also in dimensional). Let me know if anything doesn't look right. |
This is ok to go in, feel free to merge yourself when you're ready. I've added you as a collaborator to the project. |
Added extra check on length of line_entities to avoid errors if it would somehow be out of bounds
Thanks, but i've declined the request for now, maybe at a later point when I know all details of the project better. |
On constraint creation checks are added to see if it exists on the selected entity or entitiies. The exists method was added to GenericConstraintOp for this.
Line distances have been replaced for point to point distances.
linked to:
[BUG] CAD Sketcher allows us to apply the hor/vert constraints multiple times to an element #430
Cannot set Distance constraint to horizontal or vertical for lines [BUG] #459