Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of endpoint and connection management state logic #77

Merged
merged 74 commits into from
Feb 5, 2024
Merged

Conversation

neonphog
Copy link
Collaborator

@neonphog neonphog commented Dec 19, 2023

  • The main change of this PR is an inversion of the async driver for a tx5 endpoint.
    • Previously a central driver task would attempt to control all aspects, but the edge cases proved difficult to both reason about and test.
    • Now the main async driver is actually the send function. If we don't have a signal connection it will trigger creation of a cloneable future and await, following if there is no peer connection it will trigger creation of a cloneable peer connection future and await. The bulk of the complexity moves to ensuring these futures are cleaned up appropriately in error conditions.

@neonphog neonphog changed the base branch from main to async-conn-events December 19, 2023 17:23
Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering all my questions! Hopefully I contributed something as well as just learning :D PR looking good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants