Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TryCP tests running on targets #117

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

cdunster
Copy link
Contributor

@cdunster cdunster commented Oct 22, 2024

This PR makes it so that the TryCP test scenarios in the Performance workflow are actually run on the targets defined in targets.yaml as they should be.

It also updates trycp_client and trycp_api versions to 0.17.0-dev.6 to use the lair-keystore in-process instead of the binary as there is an issue with getting the connection URL from the binary (see holochain/lair#137).

TODO

  • Update changelog

ThetaSinner
ThetaSinner previously approved these changes Oct 22, 2024
@ThetaSinner
Copy link
Member

Surprised we're seeing the arx issue without having upgraded that input. I just dealt with that on the binaries repo. It needs some tweaks to the derivation definition

@cdunster
Copy link
Contributor Author

Surprised we're seeing the arx issue without having upgraded that input. I just dealt with that on the binaries repo. It needs some tweaks to the derivation definition

Yeah, I updated the tryorama input so maybe it came from there.

@cdunster cdunster force-pushed the fix-trycp-tests-running-on-targets branch from e208089 to 91b0804 Compare October 23, 2024 13:13
@cdunster cdunster force-pushed the fix-trycp-tests-running-on-targets branch from e7688a6 to 84ae3fd Compare October 24, 2024 09:11
@cdunster cdunster self-assigned this Oct 24, 2024
@cdunster cdunster added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 43afb07 Oct 24, 2024
2 checks passed
@cdunster cdunster deleted the fix-trycp-tests-running-on-targets branch October 24, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants