Fix: TryCP tests running on targets #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
previously approved these changes
Oct 22, 2024
|
Surprised we're seeing the arx issue without having upgraded that input. I just dealt with that on the binaries repo. It needs some tweaks to the derivation definition |
Yeah, I updated the |
cdunster
force-pushed
the
fix-trycp-tests-running-on-targets
branch
from
e208089
to
91b0804
Compare
cdunster
force-pushed
the
fix-trycp-tests-running-on-targets
branch
from
91b0804
to
e7688a6
Compare
cdunster
force-pushed
the
fix-trycp-tests-running-on-targets
branch
from
e7688a6
to
84ae3fd
Compare
ThetaSinner
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the TryCP test scenarios in the
Performanceworkflow are actually run on the targets defined intargets.yamlas they should be.It also updates
trycp_clientandtrycp_apiversions to0.17.0-dev.6to use thelair-keystorein-process instead of the binary as there is an issue with getting the connection URL from the binary (see holochain/lair#137).TODO