Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: TryCP tests running on targets #117

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Fix: TryCP tests running on targets #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c4f480
fix: run TryCP tests on the targets in the targets.yaml file
cdunster Oct 3, 2024
010a558
chore: update trycp client and API versions
cdunster Oct 18, 2024
8560560
fix: don't use CI conductor config for TryCP performance tests
cdunster Oct 21, 2024
84ae3fd
docs: update the changelog
cdunster Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
# Start a TryCP instance
nix develop .#ci -c bash -c "source ./scripts/trycp.sh && start_trycp &"

RUST_LOG=info CONDUCTOR_CONFIG="CI" TRYCP_RUST_LOG="info" MIN_PEERS=2 nix run .#${{ matrix.scenario }} -- --targets targets-ci.yaml --instances-per-target 2 --duration 120 --no-progress --reporter influx-file ${{ matrix.extra-args }} > >(tee logs/scenario-stdout.log) 2> >(tee logs/scenario-stderr.log >&2)
RUST_LOG=info TRYCP_RUST_LOG="info" MIN_PEERS=2 nix run .#${{ matrix.scenario }} -- --targets targets.yaml --instances-per-target 2 --duration 120 --no-progress --reporter influx-file ${{ matrix.extra-args }} > >(tee logs/scenario-stdout.log) 2> >(tee logs/scenario-stderr.log >&2)

# Stop the TryCP instance
nix develop .#ci -c bash -c "source ./scripts/trycp.sh && stop_trycp"
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
broadcast channel that it uses internally. Shutdown failures used to panic but it a `ShutdownHandle` happens to not
have any subscribers then that should not be considered a fatal error. It will now log a warning instead.
- Metrics now automatically include `run_id` and `scenario_name` tags.
- Update `trycp_client` and `trycp_api` dependencies to `v0.17.0-dev.6`. [#117](https://github.com/holochain/wind-tunnel/pull/117)

### Deprecated
### Removed
### Fixed
- Run the TryCP scenarios in the [Performance Workflow](.github/workflows/performance.yaml) on the Holo Ports defined in [targets.yaml](targets.yaml). [#117](https://github.com/holochain/wind-tunnel/pull/117)

### Security

## [0.2.0-alpha.2] - 2024-05-25
Expand Down
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ ed25519-dalek = "2.1"

# Deps for Holochain
holochain_client = { version = "=0.6.0-dev.10" }
trycp_client = { version = "0.17.0-dev.5" }
trycp_api = { version = "0.17.0-dev.5" }
trycp_client = { version = "0.17.0-dev.6" }
trycp_api = { version = "0.17.0-dev.6" }
holochain_zome_types = { version = "0.4.0-dev.18" }
holo_hash = { version = "0.4.0-dev.13" }
holochain_types = { version = "0.4.0-dev.26" }
Expand Down
1 change: 0 additions & 1 deletion bindings/trycp_runner/src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,6 @@ where
std::fs::create_dir_all(&path)
.with_context(|| format!("Failed to create log directory at {path:?}"))?;

std::fs::write(path.join("lair-stderr.log"), logs.lair_stderr)?;
std::fs::write(path.join("conductor-stdout.log"), logs.conductor_stdout)?;
std::fs::write(path.join("conductor-stderr.log"), logs.conductor_stderr)?;

Expand Down
8 changes: 4 additions & 4 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
};

tryorama = {
url = "github:holochain/tryorama?ref=v0.17.0-dev.5";
url = "github:holochain/tryorama?ref=v0.17.0-dev.6";
inputs = {
nixpkgs.follows = "nixpkgs";
crane.follows = "crane";
Expand Down