Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(gov) remove defikingdoms #157

Closed
wants to merge 4 commits into from
Closed

Conversation

fengtality
Copy link
Contributor

@fengtality fengtality commented Jul 13, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@fengtality fengtality requested a review from rapcmia July 13, 2023 23:47
Copy link
Contributor

@nikspz nikspz Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengtality Could you remove changes in this file? It was https://github.com/hummingbot/gateway/pull/141/files this PR changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do we need this files?
image

@nikspz nikspz mentioned this pull request Jul 17, 2023
2 tasks
@nikspz
Copy link
Contributor

nikspz commented Jul 17, 2023

I created new PR to remove zigzag and defikingdom without unnecessary changes
#161

@fengtality fengtality closed this Jul 17, 2023
@nikspz nikspz deleted the fix/remove-defikingdoms branch December 19, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants