Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(gov) remove defikingdoms and zigzag #161

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

nikspz
Copy link
Contributor

@nikspz nikspz commented Jul 17, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This PR do not have changes that's not related to removing connectors here: #158, #157
(yarn.lock, gateway-setup.sh and package.json files)

Tests performed by the developer:

Tips for QA testing:

@nikspz nikspz requested a review from rapcmia July 17, 2023 06:32
@nikspz nikspz requested a review from fengtality July 17, 2023 08:54
This was referenced Jul 17, 2023
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • gateway-list command does not display any of zigzag and defikingdoms
  • gateway connect does not display the removed connectors on autolist
  • gateway config does not indicate any of the remove connectors ✅

@fengtality fengtality mentioned this pull request Jul 17, 2023
2 tasks
@fengtality fengtality merged commit b3c6834 into hummingbot:development Jul 17, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants