Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(gov) remove zigzag #158

Closed
wants to merge 14 commits into from
Closed

(gov) remove zigzag #158

wants to merge 14 commits into from

Conversation

fengtality
Copy link
Sponsor Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Removed ZigZag connector pursuant to https://snapshot.org/#/hbot.eth/proposal/0x70299258a513ab4fb7ad4dd106947fd017848470fc8ce63ba4eb41b91d0d755c

Tests performed by the developer:

Tips for QA testing:

@fengtality fengtality changed the base branch from main to development July 13, 2023 23:48
@fengtality fengtality requested a review from rapcmia July 13, 2023 23:48
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengtality Could you remove changes in this file? It was https://github.com/hummingbot/gateway/pull/141/files this PR changes

Copy link
Contributor

@nikspz nikspz Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengtality Could you remove changes in this file? It was https://github.com/hummingbot/gateway/pull/141/files this PR changes

@nikspz nikspz mentioned this pull request Jul 17, 2023
2 tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes not related to zigzag removal

@nikspz
Copy link
Contributor

nikspz commented Jul 17, 2023

I created new PR to remove zigzag and defikingdom without unnecessary changes
#161

@fengtality fengtality closed this Jul 17, 2023
@fengtality fengtality deleted the fix/remove-zigzag branch July 17, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants