-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ balancer connector #280
Conversation
@vic-en Could you please fix failing tests/ add coverage? |
Was able to get 1 trade on balancer arbitrum |
@vic-en Could you please fix failing tests/ add coverage for us to be able to check and add it to this release? |
@nikspz I'm re-running the tests. I don't think the faillure is due to my change. |
FYI @fengtality @nikspz gateway/.github/workflows/workflow.yml Line 81 in be368ed
That implies several unit tests will be making call to real node endpoints as defined the the configuration templates. Aside that, I see several unit tests referencing mainnet. Those are not ideal, especially when no patch in workflow file. |
@nikspz You can now see the workflow is passing now and all I did was re-run the workflow. The hit and miss will always happen due to the numerous unpatched node urls. |
We should try with router disabled but we need a the config for that @vic-en Did you have any chance to check this feature for balancer? Could you please provide some update? |
@vic-en I think the hit-and-miss nature of the router means that this connector will need to support the |
@fengtality Balancer pools can have several tokens. At thesame time a pair of specific tokens can be availale on several pools. Unlike uniswap, there will be a challenge of which pool to use as there can be multiple pools with same pair of tokens. CC @nikspz |
…nto feat/balancer-connector
hi @vic-en please fix branch conflicts, update with latest development and continue with this PR |
@nikspz Will do and complete this weekend. |
…into feat/balancer
…o feat/balancer
@nikspz This is ready. |
@vic-en Could you please check failing tests / add coverage? |
@nikspz Again, the failling test isn't due to my changes. I mentioned this some time ago - #280 (comment) Nevertheless, I can look at that when time permits. |
I think this PR fixes the failing tests: #311 |
@vic-en Could you check avalanche? Failed to amm/price for balancer_avalanche_avalanche |
@nikspz This is updated. Avalanche now works. Also, to test with poolId just add the extra poolId in the query like below cc @fengtality |
@vic-en I tried to check amm/price works for both with and without poolId
Confirmed, works now.
|
avalanche_avalanche - trade was successful ✔ amm/trade failing for ethereum_arbitrum ❌ logs_gateway_app.log.2024-04-22.log liquidity/add ❌ |
@nikspz The LP endpoints for uniswap like contracts cannot work with Balancer. Balancer is different. Note:
|
Hi @vic-en Do you have any updates on this one? |
@nikspz I'll push the update today. |
@nikspz This is ready for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - Note small typo in logging statement @vic-en
); | ||
if (info.swaps.length === 0) { | ||
throw new UniswapishPriceError( | ||
`No pool found for ${quoteToken.address} to ${baseToken.address}.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be No pool found for ${baseToken.address} to ${quoteToken.address}.
I will merge this PR into |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Balancer connector.
Tests performed by the developer:
Tips for QA testing: