feat: update to otelgo v1.20 #222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 55 55
Lines 2248 2248
=======================================
Hits 1327 1327
Misses 861 861
Partials 60 60 ☔ View full report in Codecov by Sentry. |
| @@ -23,11 +23,10 @@ require ( | |||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 // indirect | |||
| go.opentelemetry.io/contrib/propagators/b3 v1.20.0 // indirect | |||
| go.opentelemetry.io/otel v1.20.0 // indirect | |||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.42.0 // indirect | |||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.42.0 // indirect | |||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.43.0 // indirect | |||
There was a problem hiding this comment.
i think you need to rerun go mod tidy in these sub folders? eg. go.opentelemetry.io/contrib/propagators/b3 v1.20.0 should be at 1.21.0.
There was a problem hiding this comment.
I ran make tidy, let me try running go mod tidy on each of them one by one
There was a problem hiding this comment.
no changes after individual run either. I think your diff is not showing all the commits
There was a problem hiding this comment.
oh i did not realize you can not updated the go.opentelemetry.io/contrib/propagators/b3 to v1.21.0
go.mod
Outdated
| @@ -21,10 +21,10 @@ require ( | |||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 | |||
| go.opentelemetry.io/contrib/propagators/b3 v1.20.0 | |||
There was a problem hiding this comment.
Should this be 1.21.0?
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/propagators%2Fb3%2Fv1.21.0 otel go and contrib versions are all over the place :( eg for contrib https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.21.0 - Release v1.21.0/v0.46.0/v0.15.0/v0.1.0 Depending on the module it can be one of those
There was a problem hiding this comment.
yes, different packages follow different versioning :(
| go.opentelemetry.io/otel/trace v1.19.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 | ||
| go.opentelemetry.io/contrib/propagators/b3 v1.21.0 |
There was a problem hiding this comment.
@tim-mwangi but its already 1.21.0
Upgrading otel libraries to 1.20 because of vulnerability
Checklist: