-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to otelgo v1.20 #222
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,65 @@ | ||
| module github.com/hypertrace/goagent/examples/gin-server | ||
|
|
||
| go 1.15 | ||
| go 1.20 | ||
|
|
||
| replace github.com/hypertrace/goagent => ../.. | ||
|
|
||
| require ( | ||
| github.com/gin-gonic/gin v1.9.1 | ||
| github.com/hypertrace/goagent v0.0.0-00010101000000-000000000000 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/bytedance/sonic v1.9.1 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.2.1 // indirect | ||
| github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 // indirect | ||
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/gabriel-vasile/mimetype v1.4.2 // indirect | ||
| github.com/ghodss/yaml v1.0.0 // indirect | ||
| github.com/gin-contrib/sse v0.1.0 // indirect | ||
| github.com/go-logr/logr v1.3.0 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/go-playground/locales v0.14.1 // indirect | ||
| github.com/go-playground/universal-translator v0.18.1 // indirect | ||
| github.com/go-playground/validator/v10 v10.14.0 // indirect | ||
| github.com/goccy/go-json v0.10.2 // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/google/uuid v1.3.1 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0 // indirect | ||
| github.com/hypertrace/agent-config/gen/go v0.0.0-20230126205246-bd4d81e696a6 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/klauspost/cpuid/v2 v2.2.4 // indirect | ||
| github.com/leodido/go-urn v1.2.4 // indirect | ||
| github.com/mattn/go-isatty v0.0.19 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/openzipkin/zipkin-go v0.4.2 // indirect | ||
| github.com/pelletier/go-toml/v2 v2.0.8 // indirect | ||
| github.com/twitchyliquid64/golang-asm v0.15.1 // indirect | ||
| github.com/ugorji/go/codec v1.2.11 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 // indirect | ||
| go.opentelemetry.io/contrib/propagators/b3 v1.21.0 // indirect | ||
| go.opentelemetry.io/otel v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/zipkin v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/sdk/metric v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.20.0 // indirect | ||
| go.opentelemetry.io/proto/otlp v1.0.0 // indirect | ||
| golang.org/x/arch v0.3.0 // indirect | ||
| golang.org/x/crypto v0.14.0 // indirect | ||
| golang.org/x/net v0.17.0 // indirect | ||
| golang.org/x/sys v0.14.0 // indirect | ||
| golang.org/x/text v0.13.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/grpc v1.59.0 // indirect | ||
| google.golang.org/protobuf v1.31.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,45 @@ | ||
| module github.com/hypertrace/goagent/examples/mux-server | ||
|
|
||
| go 1.15 | ||
| go 1.20 | ||
|
|
||
| replace github.com/hypertrace/goagent => ../.. | ||
|
|
||
| require ( | ||
| github.com/gorilla/mux v1.8.0 | ||
| github.com/hypertrace/goagent v0.0.0-00010101000000-000000000000 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/cenkalti/backoff/v4 v4.2.1 // indirect | ||
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/ghodss/yaml v1.0.0 // indirect | ||
| github.com/go-logr/logr v1.3.0 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/google/uuid v1.3.1 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0 // indirect | ||
| github.com/hypertrace/agent-config/gen/go v0.0.0-20230126205246-bd4d81e696a6 // indirect | ||
| github.com/openzipkin/zipkin-go v0.4.2 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 // indirect | ||
| go.opentelemetry.io/contrib/propagators/b3 v1.21.0 // indirect | ||
| go.opentelemetry.io/otel v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/zipkin v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/sdk/metric v1.20.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.20.0 // indirect | ||
| go.opentelemetry.io/proto/otlp v1.0.0 // indirect | ||
| golang.org/x/net v0.17.0 // indirect | ||
| golang.org/x/sys v0.14.0 // indirect | ||
| golang.org/x/text v0.13.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/grpc v1.59.0 // indirect | ||
| google.golang.org/protobuf v1.31.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you need to rerun go mod tidy in these sub folders? eg. go.opentelemetry.io/contrib/propagators/b3 v1.20.0 should be at 1.21.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran make tidy, let me try running go mod tidy on each of them one by one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no changes after individual run either. I think your diff is not showing all the commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i did not realize you can not updated the go.opentelemetry.io/contrib/propagators/b3 to v1.21.0