Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI style color scheme #200

Merged
merged 23 commits into from
Jun 13, 2024
Merged

GUI style color scheme #200

merged 23 commits into from
Jun 13, 2024

Conversation

chStaiger
Copy link
Collaborator

@chStaiger chStaiger commented Jun 10, 2024

  • Added new color scheme

  • Added logo

  • Small bugfixes: the sorting of the table disturbed the correct loading of the table in browser --> switched off

  • Emit when creating folders and collections in DataTransferThread

@chStaiger chStaiger linked an issue Jun 10, 2024 that may be closed by this pull request
@maartenschermer
Copy link
Collaborator

Not sure if these were introduced in this PR, but I found a few small bugs:

  • BROWSER: when I upload an existing file with Overwrite checked, it fails; logs:
ValueError: max() iterable argument is empty
2024-06-12 16:09:24,510 - ibridges-gui - ERROR - Downloading /nluu12p/home/research-test-christine/MDS/comicbooks/GB-2020-x-x-a-1-I.pdf failed: max() iterable argument is empty
Traceback (most recent call last):
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridgesgui/browser.py", line 183, in download
    download(self.session, path, download_dir, overwrite=overwrite)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 320, in download
    perform_operations(session, ops, ignore_err=ignore_err)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 382, in perform_operations
    max_size = max([*up_sizes, *down_sizes])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  • SYNC: there's no values in the 'Size in bytes' column of the list with files-top-be-synched.
  • SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"
  • SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

I've got some other ideas & suggestions, but these are the only bugs I ran into.

@chStaiger
Copy link
Collaborator Author

Not sure if these were introduced in this PR, but I found a few small bugs:

* BROWSER: when I upload an existing file with Overwrite checked, it fails; logs:
ValueError: max() iterable argument is empty
2024-06-12 16:09:24,510 - ibridges-gui - ERROR - Downloading /nluu12p/home/research-test-christine/MDS/comicbooks/GB-2020-x-x-a-1-I.pdf failed: max() iterable argument is empty
Traceback (most recent call last):
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridgesgui/browser.py", line 183, in download
    download(self.session, path, download_dir, overwrite=overwrite)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 320, in download
    perform_operations(session, ops, ignore_err=ignore_err)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 382, in perform_operations
    max_size = max([*up_sizes, *down_sizes])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* SYNC: there's no values in the 'Size in bytes' column of the list with files-top-be-synched.

* SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"

* SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

I've got some other ideas & suggestions, but these are the only bugs I ran into.

Yes I found them too. They are caused by the backend and there is already an issue for it
iBridges-for-iRODS/iBridges#191

@chStaiger
Copy link
Collaborator Author

  • SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"

Solved! thanks for finding it!

@chStaiger
Copy link
Collaborator Author

  • SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

Solved by using a differnt text widget

@chStaiger chStaiger merged commit 8f6ceb7 into develop Jun 13, 2024
6 checks passed
@chStaiger chStaiger deleted the 199-fix-browser branch June 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser table does not load correctly due to sorting
2 participants