round factor tests #7515
round factor tests #7515
Conversation
|
You may need to run rush change, based on the CI build errors - these are updates to the tests, so I would just leave the changelog comments blank |
|
I'll defer to @rschili if he believes this is enough test cases |
| }; | ||
|
|
||
| const format = new Format("test"); | ||
| await format.fromJSON(unitsProvider, formatData).catch(() => { }); |
There was a problem hiding this comment.
why catch here? Test should fail, so if the exception is thrown that should be fine?
There was a problem hiding this comment.
hmm good point. This is how format is set up in all other tests as well. I guess it means we wanna proceed with whatever information was successfully loaded into the format (even in the future they change impl of loading format), rather than failing immediately due to an exception. So allow testing with partial info? it is a bit weird.
There was a problem hiding this comment.
hm can you quickly verify that's the case? If it is, that seems like a wonky test, relying on things that are not allowed out there in the wild to compose the test inputs...
If there is no error thrown, please remove the portion
#7462