Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test-image-openj9 target fails when java -version fails #614

Merged
merged 1 commit into from
Jan 23, 2023

Commits on Jan 23, 2023

  1. Ensure test-image-openj9 target fails when java -version fails

    Previously, the exit status could come from tee, which succeeds.
    
    There is logic in make/autoconf/basics.m4 that checks for support and
    then opportunistically adds -o pipefail to SHELL in the makefiles, which
    already accomplishes the same thing, but only when pipefail support is
    detected. That should be most of the time, but it's not obvious that we
    should expect pipefail support in all cases.
    
    With this change, the target will fail whenever java -version fails,
    regardless of the pipefail setting.
    jdmpapin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    22b0ac1 View commit details
    Browse the repository at this point in the history