Ensure test-image-openj9 target fails when java -version fails #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Jan 19, 2023
Previously, the exit status could come from tee, which succeeds. There is logic in make/autoconf/basics.m4 that checks for support and then opportunistically adds -o pipefail to SHELL in the makefiles, which already accomplishes the same thing, but only when pipefail support is detected. That should be most of the time, but it's not obvious that we should expect pipefail support in all cases. With this change, the target will fail whenever java -version fails, regardless of the pipefail setting.
jdmpapin
force-pushed
the
version-exit-status
branch
from
192d8ee
to
22b0ac1
Compare
|
Added quotes for consistency |
|
Jenkins compile alinux64 jdk11 |
keithc-ca
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the exit status could come from
tee, which succeeds.There is logic in
make/autoconf/basics.m4that checks for support and then opportunistically adds-o pipefailtoSHELLin the makefiles, which already accomplishes the same thing, but only whenpipefailsupport is detected. That should be most of the time, but it's not obvious that we should expectpipefailsupport in all cases.With this change, the target will fail whenever
java -versionfails, regardless of thepipefailsetting.