Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opencpu client dev #271
Opencpu client dev #271
Changes from 16 commits
f6c223c
bba0b18
3cbd9bf
03b1348
7f04862
6412f91
8071dfb
8dd8d56
6c93b24
294788d
548af2e
a61a4bb
a53ca14
0f09947
970ed50
e24e20d
b6cc350
e402c03
f37593f
c6a946c
420f9d5
6c2d358
71855e3
d7d7fca
cb8592e
35543b7
05d090c
2013180
bab4e23
2ec1692
cc7a49d
084db7c
ff805be
34f7321
ceacf65
ad23e46
d5839e4
d13017f
353fa82
e369a55
236f107
e69c253
24cd2b8
39be8f8
d7b6e9a
1c24bfc
be3fac2
d1a2b06
908e475
083dd21
785eda7
4dede99
b959fa1
976d4c1
86056c0
3efcdda
32c66c6
a06a0e9
d95daed
268e229
8569e9e
380e1c7
68b9a25
f64c685
78befb3
92c913a
8d9a001
4227e96
5f21753
6dcdb49
263a8bc
4515193
bf8c53a
c83fe53
0ef96bd
d571322
1bbdf1a
2876812
ca4b2ad
98c3fe8
575e807
ebf37e9
8dd182e
5ec65d3
feab756
2aec8f0
7c43da5
7e7f461
53c9a4b
bfc8e50
b913ae2
f1877cb
41740ff
dfa8bdb
ccafee2
67e8517
c88a557
aec4376
fc73cd7
3e9ab7f
0e1f46b
fb2ecf3
f05ba25
69eaadd
2beb284
548de57
72e1010
a6fcdab
04b9f4d
f9cbaed
2333b61
1225180
aab9a83
3ec17bb
a7c351c
6be039c
25af9cf
0b714cf
47963f5
9b08304
3d6975f
dedcc02
bc02917
d161e91
0a93b7d
b4cc8f4
abf89c1
f035d96
af94b67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make more succinct and refrain from using comma's in function titles:
With the different credentials floating around (R Studio server, applications, DB) we should probably figure out how these can be called consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this function is referenced in the documentation of params, I would make this a public function (even if that means users can store their credentials in a variable). I notice the same is done for e.g.
show_progress()
,readr_threads()
in https://readr.tidyverse.org/reference/read_delim.htmlSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.