Fix json request type in payload #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log error on exception Check logger extension is present before attempting to log
…esence of NOTIFY_URL, route the flask debugger into the service to allow logging to actually work
… class remove the extension class which really isn't used beyond initialisation notify_init is now the path for initialising the service
isort ran remove non-pythonic empty check remove incorrect return type hinting reduce indents by returning early on notify_init
|
Please remove all the unrelated stuff from the PR, such as the package-lock.json change. |
|
Literally half a second to slow. |
|
Thanks. For the future I recommend rebasing onto the upstream master branch to avoid having tons of commit. I'll squash+merge so they don't show up in master, but still, it's much cleaner to not have them in the first place ;) |
|
My bad. Ill ensure to do that in the future. thanks |
ThiefMaster
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to actually send the data as a json request so the appropriate header typing prompts the microservice platform I am using to serialise the request payload.