Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json request type in payload #9

Merged
merged 11 commits into from
Apr 23, 2024
Merged

Fix json request type in payload #9

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc6bcb4
Add notification for third party services
joshpme Dec 8, 2023
5420ceb
PR suggestions
joshpme Dec 8, 2023
3df2275
PR suggestion, change parameter context to app
joshpme Dec 10, 2023
9d826b5
Log whether or not the notify service was initialised based on the pr…
joshpme Dec 10, 2023
39d27ef
Change naming to reflect their rolls. E.g. notify service is the only…
joshpme Dec 10, 2023
c0024fa
Move environmental call into init function to make app init less messy
joshpme Dec 10, 2023
5175359
Merge with indico
joshpme Feb 27, 2024
3586c1c
PR comments actioned
joshpme Apr 10, 2024
14e929a
Actually send the data as a request payload
joshpme Apr 23, 2024
79373ff
merge changes from indico
joshpme Apr 23, 2024
7273075
undo package-lock change
joshpme Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openreferee_server/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def log_error(self, *args):

def send(self, payload):
try:
self.session.post(self.url, data=json.dumps({"payload": payload}))
self.session.post(self.url, json={"payload": payload})
ThiefMaster marked this conversation as resolved.
Show resolved Hide resolved
except HTTPError as e:
self.log_error("Invalid response from notify: %s", str(e))
except ConnectionError as e:
Expand Down
Loading