-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV compressor implementation #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
For review pass I would think we are wasting a good opportunity to kill prometheus-remote
. It served its purpose, but CSV integration will be easier to use. For this lib_vsri.rs
this to be moved into it's own crate (and we need a different PR for that).
Also remove any IDE artifacts.
Good work, thanks!
Hello @cjrolo. Thanks a lot for your feedback! I like the idea of creating a new crate for VSRI lib. I'll handle this one. Also, I'll update this PR after VSRI crate is merged. |
416f594
to
00dfec8
Compare
@rukai Can you please review this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to avoid blocking with timezones, please address the feedback before merging.
Hey @rukai, thanks a lot for your feedback! |
7a4713e
to
0310eba
Compare
Oof, I finally did it. This GitHub linter makes me crazy because of those indents! @rukai, could you please look at this one again? I've updated the PR following your suggestions. I hope it looks a bit better now. Thanks! |
I'll take a proper look tomorrow since I'm finished for the day, but just so you know you can run |
log = "0.4.19" | ||
env_logger = "0.10.0" | ||
vsri = { version = "0.1.0", path = "../vsri" } | ||
tempdir = "0.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only used for tests it should be included as a dev-dependency so it does not need to be built when building just csv-compressor without the tests.
tempdir = "0.3.7" | |
[dev-dependencies] | |
tempdir = "0.3.7" |
I made |
@rukai Thanks a lot! |
Overview
This PR adds csv-compressor cli tool which utilizes Brro Compressor functionality to compress CSV formatted metrics data.
All parsed data from CSV is stored in a single WavBrro and Vsri for solution simplification.
Compress flow
Currently, it only parses CSV data of the following structure:
Decompress flow