Vsri lib crate #95
Merged
Vsri lib crate #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
force-pushed
the
vsri-lib-extraction
branch
4 times, most recently
from
2eb2872 to
8e85022
Compare
worryg0d
force-pushed
the
vsri-lib-extraction
branch
from
8e85022 to
706652a
Compare
cjrolo
approved these changes
Jul 24, 2024
|
Requesting @rukai to look at this. |
rukai
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
I took a quick look over this, mostly from the perspective of how rust is used.
I noticed a few minor things but nothing impacting correctness.
Looks good!
I also note that csv is an inefficient way of storing integers, but I assume @cjrolo has a good reason for wanting to use csv.
|
@rukai thanks a lot for your feedback! Your suggestions are good and make the general codebase look cleaner here. I'll include them in this PR. Thank you! |
Co-authored-by: Lucas Kent <rubickent@gmail.com>
worryg0d
force-pushed
the
vsri-lib-extraction
branch
from
1d3ffbb to
673d4cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #94, this PR new lib vsri duplicates the implementation of
vsri_lib.rsfrom prometheus-remote crate.