Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement dynamic tracks addition with renegotiation (#27) #105

Merged
merged 75 commits into from
Jun 26, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented May 22, 2020

Part of #27

Required for #89

Synopsis

We need to implement renegotiation functional for ICE restarts (#89) and MediaTracks updating (adding new Endpoints to an already going call).

Solution

  • 1. Add RenegotiationStarted and SdpOfferMade Events.
  • 2. Implement renegotiation on a server side
  • 3. Lock Peer's state until renegotiation finish (will be done in a separate PR)
  • 4. Implement renegotiation on a client side

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels May 22, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone May 22, 2020
@evdokimovs evdokimovs self-assigned this May 22, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Jun 23, 2020

FCM

Implement dynamic tracks addition with renegotiation (#105, #27)

- support adding new endpoints to the already interconnected Members
- implement PeerConnection renegotiation
- add TracksApplied event

@evdokimovs evdokimovs requested a review from alexlapa June 23, 2020 16:40
@alexlapa alexlapa changed the title WIP: Implement renegotiation (#27) WIP: Implement dynamic tracks addition with renegotiation (#27) Jun 25, 2020
@alexlapa alexlapa requested a review from tyranron June 25, 2020 18:30
@tyranron tyranron added the k::design Related to overall design and/or architecture label Jun 26, 2020
@tyranron tyranron changed the title WIP: Implement dynamic tracks addition with renegotiation (#27) Implement dynamic tracks addition with renegotiation (#27) Jun 26, 2020
@evdokimovs evdokimovs merged commit 55cb227 into master Jun 26, 2020
@evdokimovs evdokimovs deleted the renegotiation branch June 26, 2020 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants