Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add traffic watcher services for the on_start/on_stop callbacks (#27) #98

Merged
merged 22 commits into from
May 11, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Apr 28, 2020

Part of #27

Required for #91

Synopsis

#91 has become too big. And it was decided to break it into several PRs.

This part of #91 is responsible for the RTCStats (received from a client) processing and for watching that traffic is flows normally. Also in this PR is implemented service which put together stats from the Coturn and a client, and based on this stats makes decision about Peer's traffic flowing.

This PR is just part of the on_start/on_stop Control API callbacks implementations. It's doesn't adds new functional and needed only for the code review simplification.

Solution

Pick peers module and important for this module things from the #91.

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::monitoring Related to monitoring capabilities labels Apr 28, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Apr 28, 2020
@evdokimovs evdokimovs self-assigned this Apr 28, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Apr 28, 2020

FCM

Add traffic watcher services for the 'on_start'/'on_stop' callbacks (#98, #27)

- add service which puts together client's stats and Coturn's stats
- add service for the client's RTCStats processing
- add [media] section to app's config with traffic watcher timeouts

Additionally:
- fix #[enum_dispatchable] macro to work fine with multi-arg functions

@evdokimovs evdokimovs marked this pull request as ready for review April 28, 2020 15:08
@evdokimovs evdokimovs requested a review from alexlapa April 28, 2020 15:32
@alexlapa alexlapa removed k::monitoring Related to monitoring capabilities k::design Related to overall design and/or architecture labels May 4, 2020
@alexlapa alexlapa requested a review from tyranron May 6, 2020 11:56
@tyranron tyranron added k::design Related to overall design and/or architecture k::config Related to application configuration and removed k::api Related to API (application interface) labels May 11, 2020
@tyranron tyranron changed the title WIP: Add traffic watcher services for the on_start/on_stop callbacks (#27) Add traffic watcher services for the on_start/on_stop callbacks (#27) May 11, 2020
@evdokimovs evdokimovs merged commit faab5bf into master May 11, 2020
@evdokimovs evdokimovs deleted the traffic-watchers-impl branch May 11, 2020 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::config Related to application configuration k::design Related to overall design and/or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants