Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream pytorch/benchmark for E2E tests, no IPEX #1612

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

pbchekin
Copy link
Contributor

Also renaming e2e to e2e-accuracy for consistency with other workflows.

Fixes #1610.

Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any functional or performance regressions?

@pbchekin
Copy link
Contributor Author

Are there any functional or performance regressions?

Hard to say, the workflow without IPEX does not work properly with forked pytorch/benchmark. This PR adds an option to run E2E accuracy/performance in both modes: with and without IPEX. I will run both tonight and we can compare the results row to row.

Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still running the workflows with IPEX by default. This PR changes to use the correct benchmark when IPEX is not used during manual testing.

@pbchekin pbchekin merged commit 7fc8e2b into llvm-target Jul 11, 2024
4 checks passed
@pbchekin pbchekin deleted the 1607-upstream-torchbench branch July 11, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use upstream pytorch/benchmark for E2E tests
2 participants