Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream pytorch/benchmark for E2E tests, no IPEX #1612

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Use upstream pytorch/benchmark for E2E tests, no IPEX #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2ff35b
Use upstream torchbench
pbchekin Jul 11, 2024
58ab36e
Custom run name
pbchekin Jul 11, 2024
22255d2
Fix getting commit id
pbchekin Jul 11, 2024
29036f4
Rename workflow
pbchekin Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/e2e.yml → .github/workflows/e2e-accuracy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: E2E accuracy
run-name: ${{ inputs.run_name }}

on:
workflow_dispatch:
Expand Down Expand Up @@ -54,6 +55,10 @@ on:
description: TORCH_COMPILE_DEBUG
type: string
default: ""
run_name:
description: Custom run name
type: string
default: "E2E accuracy"

permissions: read-all

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/e2e-performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: E2E performance
run-name: ${{ inputs.run_name }}

on:
workflow_dispatch:
Expand Down Expand Up @@ -54,6 +55,10 @@ on:
description: TORCH_COMPILE_DEBUG
type: string
default: ""
run_name:
description: Custom run name
type: string
default: "E2E performance"

permissions: read-all

Expand Down
34 changes: 25 additions & 9 deletions .github/workflows/e2e-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ env:
TRITON_DISABLE_LINE_INFO: 1
PYTHON_VERSION: "3.10"
BENCHMARK_REPO: weishi-deng/benchmark.git
BENCHMARK_BRANCH: main
TORCH_XPU_OPS_COMMIT: 39522db63ce045f52c9d61a286018c266cd00479

jobs:
Expand All @@ -66,13 +65,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Get benchmark commit id
uses: ./.github/actions/get-commit-id
with:
repository: ${{ env.BENCHMARK_REPO }}
branch: ${{ env.BENCHMARK_BRANCH }}
variable: BENCHMARK_COMMIT_ID

- name: Load pip cache
id: pip-cache
uses: ./.github/actions/load
Expand Down Expand Up @@ -101,6 +93,30 @@ jobs:
repository: pytorch/pytorch
torch_xpu_ops_commit: ${{ env.TORCH_XPU_OPS_COMMIT }}

- name: Set benchmark repository (IPEX)
if: ${{ inputs.install_ipex }}
run: |
echo "BENCHMARK_REPO=weishi-deng/benchmark" | tee -a "$GITHUB_ENV"

- name: Set benchmark repository (PyTorch)
if: ${{ !inputs.install_ipex }}
run: |
echo "BENCHMARK_REPO=pytorch/benchmark" | tee -a "$GITHUB_ENV"

- name: Get benchmark commit id (IPEX)
if: ${{ inputs.install_ipex }}
uses: ./.github/actions/get-commit-id
with:
repository: ${{ env.BENCHMARK_REPO }}
branch: main
variable: BENCHMARK_COMMIT_ID

- name: Get benchmark commit id (PyTorch)
if: ${{ !inputs.install_ipex }}
run: |
cd pytorch
echo "BENCHMARK_COMMIT_ID=$(<.github/ci_commit_pins/torchbench.txt)" | tee -a "$GITHUB_ENV"

- name: Identify pinned versions
run: |
cd pytorch
Expand Down Expand Up @@ -200,7 +216,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: ${{ env.BENCHMARK_REPO }}
ref: ${{ env.BENCHMARK_BRANCH }}
ref: ${{ env.BENCHMARK_COMMIT_ID }}
submodules: recursive
path: benchmark

Expand Down