Skip to content

Commit

Permalink
[SYCL][COMPAT] NVPTX nd_range_barrier seq_cst memory order
Browse files Browse the repository at this point in the history
  • Loading branch information
Alcpz committed Apr 9, 2024
1 parent 1ff4250 commit 1d8aaa4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions sycl/doc/syclcompat/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1129,8 +1129,8 @@ spec, and so should be used with caution.
namespace syclcompat {
namespace experimental {
#if defined(__AMDGPU__) || defined(__NVPTX__)
// seq_cst currently not working with AMD and Nvidia Backends
#if defined(__AMDGPU__)
// seq_cst currently not working for AMD
constexpr sycl::memory_order barrier_memory_order = sycl::memory_order::acq_rel;
#else
constexpr sycl::memory_order barrier_memory_order = sycl::memory_order::seq_cst;
Expand Down
4 changes: 1 addition & 3 deletions sycl/include/syclcompat/util.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ inline int get_sycl_language_version() {

namespace experimental {

#if defined(__AMDGPU__) || defined(__NVPTX__)
// FIXME: https://github.com/intel/llvm/pull/12516 adds seq_cst support for the
// CUDA backend.
#if defined(__AMDGPU__)
constexpr sycl::memory_order barrier_memory_order = sycl::memory_order::acq_rel;
#else
constexpr sycl::memory_order barrier_memory_order = sycl::memory_order::seq_cst;
Expand Down

0 comments on commit 1d8aaa4

Please sign in to comment.