[SYCL][UR] Combined CTS fixes for CL adapter. #11794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
force-pushed
the
aaron/opencl-cts-fixes-combined
branch
from
d098f70
to
ab321fb
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
force-pushed
the
aaron/opencl-cts-fixes-combined
branch
from
ab321fb
to
76a4777
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
force-pushed
the
aaron/opencl-cts-fixes-combined
branch
from
76a4777
to
d9eefd5
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
force-pushed
the
aaron/opencl-cts-fixes-combined
branch
from
10bf762
to
7ddce35
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Not that oneapi-src/unified-runtime#1044 has merged, please pull in the latest sycl branch changes and update the UNIFIED_RUNTIME_REPO/UNIFIED_RUNTIME_TAG values as suggested. Then make this PR ready to review.
Pulls in fixes from oneapi-src/unified-runtime#1044 New UR commit hash 192e9404392c38ac43d09116d6c97e153c66f46b Also correct type in a couple of NUM_DEVICES PI queries, and implement a workaround in pi2ur for type mismatch between PI kernel num args query and UR equivalent.
aarongreig
force-pushed
the
aaron/opencl-cts-fixes-combined
branch
from
81ff919
to
4bfc140
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
approved these changes
Nov 10, 2023
|
@intel/llvm-reviewers-runtime please review, it is intended for the next release. |
| @@ -2336,8 +2336,18 @@ inline pi_result piKernelGetInfo(pi_kernel Kernel, pi_kernel_info ParamName, | |||
| break; | |||
| } | |||
| case PI_KERNEL_INFO_NUM_ARGS: { | |||
| UrParamName = UR_KERNEL_INFO_NUM_ARGS; | |||
| break; | |||
| size_t NumArgs = 0; | |||
There was a problem hiding this comment.
Why do use use different types for different Num*?
There was a problem hiding this comment.
It turned out this particular query has always been size_t in UR, one of the fixes we're pulling in causes that to be properly validated now so we need to do this bit of translation. We do plan to fix this for the next release cycle oneapi-src/unified-runtime#1038
aelovikov-intel
approved these changes
Nov 14, 2023
17 tasks
callumfare
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in fixes from oneapi-src/unified-runtime#1044