Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCL] Combined CTS fixes #1044

Merged
merged 20 commits into from
Nov 10, 2023

Conversation

@aarongreig aarongreig requested review from a team as code owners November 6, 2023 12:17
Also includes a few other GetInfo related fixes:
* Add missing device info queries
* Add mapping of CL command type to UR command type
* Correct mapping of UR_QUEUE_INFO_FLAGS
* Add mapping of cl_command_queue_properties to ur_queue_flags_t
* Add mapping of cl_unified_shared_memory_type_intel to ur_usm_type_t
* Add UNSUPPORTED_ENUMERATION path to KernelGeGroupInfo tests.

And a fix related to one of the fixed queries:
* Populate pfnReadHostPipe and pfnWriteHostPipe ddi table entries.
@aarongreig aarongreig added the conformance Conformance test suite issues. label Nov 6, 2023
@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Nov 8, 2023
This allows us to return UR_ERROR_INVALID_SIZE when we should. Extra
checks are only performed on a non-success error code.

Also adds a missing bounds check to urMemBufferPartition
@kbenzie kbenzie merged commit 192e940 into oneapi-src:adapters Nov 10, 2023
87 of 95 checks passed
aarongreig added a commit to aarongreig/intel-llvm that referenced this pull request Nov 10, 2023
Pulls in fixes from oneapi-src/unified-runtime#1044

New UR commit hash 192e9404392c38ac43d09116d6c97e153c66f46b

Also correct type in a couple of NUM_DEVICES PI queries, and  implement
a workaround in pi2ur for type mismatch between PI kernel num args query
and UR equivalent.
aelovikov-intel pushed a commit to intel/llvm that referenced this pull request Nov 14, 2023
callumfare pushed a commit to kbenzie/llvm that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants