Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Bindless] 1D Image copy fix #12342

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

cppchedy
Copy link
Contributor

@cppchedy cppchedy commented Jan 10, 2024

Fix copying problem for 1d images in both directions, from device to host and host to device.

@aarongreig
Copy link
Contributor

@cppchedy oneapi-src/unified-runtime#1240 has merged, please update

@cppchedy
Copy link
Contributor Author

cppchedy commented Feb 5, 2024

@aarongreig thanks, updated.

@aarongreig aarongreig marked this pull request as ready for review February 6, 2024 09:48
@aarongreig aarongreig requested a review from a team as a code owner February 6, 2024 09:48
Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the description as well

@aarongreig
Copy link
Contributor

oh and I guess you'll need to re-resolve the conflict, this always gets fiddly when we're trying to merge UR bumps back to back

@cppchedy cppchedy changed the title [Bindless] 1D Image copy fix [SYCL][Bindless] 1D Image copy fix Feb 6, 2024
@aarongreig
Copy link
Contributor

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit e0324da into intel:sycl Feb 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants