[Bindless][exp] 1D Image copy fix #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 15.39% 15.39%
=======================================
Files 240 240
Lines 34122 34122
Branches 3779 3779
=======================================
+ Hits 5252 5253 +1
+ Misses 28819 28818 -1
Partials 51 51 ☔ View full report in Codecov by Sentry. |
isaacault
approved these changes
Jan 10, 2024
przemektmalon
approved these changes
Jan 19, 2024
Seanst98
approved these changes
Jan 19, 2024
cppchedy
force-pushed
the
chedy/fix-bi-copy-image
branch
2 times, most recently
from
4eb9d98
to
2ce83d7
Compare
cppchedy
force-pushed
the
chedy/fix-bi-copy-image
branch
2 times, most recently
from
6e1074b
to
b417e3a
Compare
* image handles created using memory allocated by `malloc_device` crashes when copied. * identify which type of memory is copied and use the correct cuda API for it.
cppchedy
force-pushed
the
chedy/fix-bi-copy-image
branch
from
b417e3a
to
cf806c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 1D copies that uses USM pointers.
corresponding PR in intel/llvm#12342 only for CI