[SYCL] Throw exception for unsupported UR features #12361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| "Platform create with native handle command not supported by backend."); | ||
| } else { | ||
| Plugin->checkPiResult(Result); | ||
| } |
There was a problem hiding this comment.
This pattern seems to repeat a lot. Could we maybe make a new call_optional or call_ext or something along those lines?
There was a problem hiding this comment.
Thanks for your suggestion, it certainly would be good to refactor out the repetitiveness here. I wonder if it might be worth putting the check inside the pre-existing call or call_nocheck functions?
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/urUnsupportedFeature
branch
from
f1689f3
to
1701ed6
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…TION as receiving UR_RESULT_ERROR_UNSUPPORTED_FEATURE from Unified Runtime and throw an appropriate exception. Added a new e2e test to check the error is handled correctly.
martygrant
force-pushed
the
martin/urUnsupportedFeature
branch
from
1701ed6
to
649e8d9
Compare
…tion isn't thrown.
martygrant
force-pushed
the
martin/urUnsupportedFeature
branch
from
649e8d9
to
c9c70e2
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stemming from removing
diecalls in unsupported UR entry points (oneapi-src/unified-runtime#1127) and a spin-out issue discussing how to handle these errors in intel-llvm (oneapi-src/unified-runtime#1161).This PR changes various PI entry points to interpret
PI_ERROR_INVALID_OPERATIONas receivingUR_RESULT_ERROR_UNSUPPORTED_FEATUREand will throw a SYCL exception with error codesycl::errc::feature_not_supported.A new e2e test has been added (
Plugin/ur_unsupported_feature.cpp) which is meant to purposely call an unsupported UR entry point and will assert that an exception is thrown specifically with codesycl::errc::feature_not_supportedto ensure we are handling unsupported features from UR in intel-llvm appropriately.