[SYCL][Graph] Add node and graph queries for mixed usage #12366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement graph and node queries from spec - New node_type enum - Note, subgraph node type not yet implemented due to significant changes required - Explicit nodes now also have associated events (fixes mixed usage issue) - New tests for queries - Update linux ABI symbols
- Subgraphs are now stored in modifiable graphs as a single node, instead of being merged - Executable graphs copy all nodes internally (pre-partitioning) and merge subgraph nodes into the main node list - Subgraph merging no longer uses empty nodes - Subgraph nodes now use CGExecCommandBuffer instead of being empty - CGExecCommandBuffer now stores exec graph (to pass to node) - Modifications to unit tests due to internals changing - Added dot printing for exec_graph_impl as an internal debugging feature
EwanC
reviewed
Jan 18, 2024
EwanC
reviewed
Jan 19, 2024
mfrancepillois
approved these changes
Jan 19, 2024
EwanC
approved these changes
Jan 22, 2024
|
ping @intel/llvm-reviewers-runtime for review |
|
ping @intel/llvm-reviewers-runtime |
steffenlarsen
approved these changes
Feb 9, 2024
reble
reviewed
Feb 9, 2024
Bensuo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds queries to both nodes and modifiable graphs which enable better mixed usage of both the explicit and record & replay APIs in a single program.
It also reworks how subgraphs are handled: previously nodes were merged into the modifiable graph, but this would pose a problem for users querying the graph since they would not see a single subgraph node, and this merging behaviour was an implementation detail. This has been changed so that now subgraph nodes are only merged in the executable graph, and are stored as a single node of type
subgraphin the modifiable graph.As a consequence of this change all nodes are now also copied when making the executable graph, where previously they were not.