Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bindless][Exp] Add texture fetch functionality #12447

Merged
merged 67 commits into from
May 2, 2024
Merged

[Bindless][Exp] Add texture fetch functionality #12447

merged 67 commits into from
May 2, 2024

Conversation

przemektmalon
Copy link
Contributor

@przemektmalon przemektmalon commented Jan 19, 2024 •
edited
Loading

With this commit, it is now possible to "fetch" sampled image data by passing integer coordinates and a sampled_image_handle to the fetch_image function.

@przemektmalon
[Bindless][Exp] Add texture fetch functionality
3ea1db3 
With this commit, it is now possible to "fetch" sampled image data by
passing integer coordinates to the `read_image` funtion.
@przemektmalon przemektmalon mentioned this pull request Jan 19, 2024
Merged
@przemektmalon przemektmalon marked this pull request as ready for review February 6, 2024 14:45
@przemektmalon przemektmalon requested review from a team as code owners February 6, 2024 14:45
@przemektmalon
Copy link
Contributor Author

przemektmalon commented Feb 6, 2024 •
edited
Loading

Note that this PR is dependent on the following UR PR: oneapi-src/unified-runtime#1264 oneapi-src/unified-runtime#1535

Once the above is merged I will update the UR TAG in the CMakeLists. Otherwise this is ready for review.

@kbenzie kbenzie mentioned this pull request Apr 17, 2024
Merged
@przemektmalon przemektmalon mentioned this pull request Apr 22, 2024
Merged
@kbenzie
Copy link
Contributor

kbenzie commented May 2, 2024

@intel/llvm-gatekeepers please merge

@steffenlarsen steffenlarsen merged commit d13fdbe into intel:sycl May 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@gmlueck gmlueck gmlueck left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@DBDuncan DBDuncan DBDuncan approved these changes

@aarongreig aarongreig aarongreig approved these changes

@isaacault isaacault isaacault approved these changes

@Seanst98 Seanst98 Seanst98 approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@kbenzie kbenzie kbenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@przemektmalon @kbenzie @cperkinsintel @gmlueck @AlexeySachkov @Seanst98 @isaacault @aarongreig @DBDuncan @steffenlarsen