[Bindless][Exp] Add device queries for sampled image fetch #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
|
Related DPC++ PR: intel/llvm#12447 |
|
Should we close #1529? |
|
@przemektmalon yeah not problem, I agree it'll be easier for you to work on your own fork if any changes are necessary. |
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
8f62b5a
to
56142ad
Compare
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
56142ad
to
8a4e378
Compare
Added the following queries for device capabilities of fetching sampled images: - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_EXP
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
8a4e378
to
8f37503
Compare
|
Pinging @oneapi-src/unified-runtime-bindless-images-write @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-maintain @GeorgeWeb. This PR was merged before and reverted due to DPC++ CI failures and higher priority PRs coming in. The code from the original PR hasn't changed, and DPC++ CI now passes. Reviews/approvals appreciated! |
Seanst98
approved these changes
May 2, 2024
kbenzie
approved these changes
May 2, 2024
|
Since this was already approved before being reverted I'll go ahead an merge this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following queries for device capabilities of fetching sampled images: